Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number formatting in additional Y axis in (evolution) charts #19360

Merged
merged 2 commits into from Jun 28, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 15, 2022

Description:

While reviewing another PR I saw that the additional y axis values in evolution charts were not formatted:

image

This PR will change the behavior, so the number formatter is set for all available y axis.

Review

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Jun 15, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 15, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested before and after the change, also configured some evolution charts with percent and time values as the second y-axis to confirm that non-floats are handled too. Works well 👍

@sgiehl sgiehl merged commit df9b363 into 4.x-dev Jun 28, 2022
@sgiehl sgiehl deleted the fixy2axislabel branch June 28, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants