Improve password reset email formatting #19357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bx80
added
Bug
bx80
added
the
not-in-changelog
sgiehl
reviewed
Jun 15, 2022
sgiehl
approved these changes
Jun 21, 2022
|
@bx80 some tests had been failing due to the last change (as they try to grep the token from the email content). I've pushed a simple fix for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #19354
Quick fix for plain text and HTML password reset emails.
A non-HTML body is now added to the email so the link is properly displayed for plain text email clients.
The HTML body paragraph element containing the link now has inline styling added to prevent the reset link overflowing off the screen/page.
Review