Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Add url property to MatomoUrl to hold entire URL string #19348

Merged
merged 1 commit into from Jun 13, 2022

Conversation

diosmosis
Copy link
Member

Description:

Adding this property and making urlQuery/hashQuery computed properties, makes it easier to watch the entire URL as it changes, eg:

watch(MatomoUrl.url, (newValue, oldValue) => {
  // ...
});

Will be used in AnonymousPiwikUsageMeasurement.

Review

@sgiehl sgiehl merged commit a41afe5 into 4.x-dev Jun 13, 2022
@sgiehl sgiehl deleted the vue-matomo-url-whole-url-property branch June 13, 2022 07:37
peterhashair pushed a commit that referenced this pull request Jun 16, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants