Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FAQ links using # in the link no longer working #19346

Closed
Starker3 opened this issue Jun 13, 2022 · 1 comment · Fixed by #19347
Closed

Fix FAQ links using # in the link no longer working #19346

Starker3 opened this issue Jun 13, 2022 · 1 comment · Fixed by #19347
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.12.0

Comments

@Starker3
Copy link
Contributor

refs DEV-2838

With the recent KB system update any FAQ links that use a # anchor link no longer link to the correct FAQ. For example https://matomo.org/faq/general/#faq_125 just links to the general page, but https://matomo.org/faq/general/faq_125 works as expected.

There are several FAQ links in the codebase that are now effectively broken.
Eg. there is this one:

matomo/plugins/CoreUpdater/templates/runUpdaterAndExit_welcome.twig

Line 54 in 2b35b46

<p>{{ 'CoreUpdater_HighTrafficPiwikServerEnableMaintenance'|translate('<a target="_blank" rel="noreferrer noopener" href="https://matomo.org/faq/how-to/#faq_111">', '</a>')|raw }}</p>

that is supposed to go to https://matomo.org/faq/how-to/faq_111/

But because of the # in the faq link it goes to the KB homepage: https://matomo.org/guides/#faq_111
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Jun 13, 2022
@bx80
Copy link
Contributor

bx80 commented Jun 13, 2022

Just to clarify, the task here is to update all FAQ links in core that use # in URL so they work again.

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. Needs priority decision This issue may need to be added to the current milestone by Product Manager and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Jun 13, 2022
@bx80 bx80 added this to the For Prioritization milestone Jun 13, 2022
@Starker3 Starker3 mentioned this issue Jun 13, 2022
Merged
11 tasks
@sgiehl sgiehl modified the milestones: For Prioritization, 4.12.0 Jun 13, 2022
@sgiehl sgiehl removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Jun 13, 2022
@justinvelluppillai justinvelluppillai changed the title FAQ links using # in the link no longer work Fix FAQ links using # in the link no longer working Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging a pull request may close this issue.

Fix FAQ # links
3 participants
@sgiehl @Starker3 @bx80