Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik-field file passthru uiControlAttributes #19336

Open
ulcuber opened this issue Jun 10, 2022 · 3 comments
Open

Piwik-field file passthru uiControlAttributes #19336

ulcuber opened this issue Jun 10, 2022 · 3 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@ulcuber
Copy link
Contributor

ulcuber commented Jun 10, 2022

Maybe v-bind="uiControlAttributes" for input in FieldFile.vue

Summary

For example:

<div
    piwik-field
    uicontrol="file"
    name="name"
    required
</div>

Expected:

<input name="name" type="file" id="name" required>

Actual:

<input name="name" type="file" id="name">
@ulcuber ulcuber added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 10, 2022
@sgiehl
Copy link
Member

sgiehl commented Jun 10, 2022

@diosmosis are you able to answer that one?

@diosmosis
Copy link
Member

@sgiehl this was how the original angularjs field was defined:

https://github.com/matomo-org/matomo/blob/f57a5313f7923c60e55c2b101351bccaae287330/plugins/CorePluginsAdmin/angularjs/form-field/field-file.html

compare with:

piwik-attributes="{{formField.uiControlAttributes}}"

If I understand correctly this ticket is about adding new behavior to file fields, allowing uiControlAttributes to be passed to the input in them. It's not a regression or question.

@sgiehl
Copy link
Member

sgiehl commented Jun 13, 2022

@diosmosis Ok. Thanks for clarifying that. Wasn't sure if that was the same behavior before.
@ulcuber If you are able to provide a PR to change that, we would be happy to review and merge this.
Otherwise our product team will review and might plan this in.

@sgiehl sgiehl added this to the For Prioritization milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants