@ulcuber opened this Issue on June 10th 2022 Contributor

Maybe v-bind="uiControlAttributes" for input in FieldFile.vue

Summary

For example:

<div
    piwik-field
    uicontrol="file"
    name="name"
    required
</div>

Expected:

<input name="name" type="file" id="name" required>

Actual:

<input name="name" type="file" id="name">
@sgiehl commented on June 10th 2022 Member

@diosmosis are you able to answer that one?

@diosmosis commented on June 10th 2022 Member

@sgiehl this was how the original angularjs field was defined:

https://github.com/matomo-org/matomo/blob/f57a5313f7923c60e55c2b101351bccaae287330/plugins/CorePluginsAdmin/angularjs/form-field/field-file.html

compare with: https://github.com/matomo-org/matomo/blob/f57a5313f7923c60e55c2b101351bccaae287330/plugins/CorePluginsAdmin/angularjs/form-field/field-text.html#L9

If I understand correctly this ticket is about adding new behavior to file fields, allowing uiControlAttributes to be passed to the input in them. It's not a regression or question.

@sgiehl commented on June 13th 2022 Member

@diosmosis Ok. Thanks for clarifying that. Wasn't sure if that was the same behavior before.
@ulcuber If you are able to provide a PR to change that, we would be happy to review and merge this.
Otherwise our product team will review and might plan this in.

Powered by GitHub Issue Mirror