Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to handle incorrectly prefixed region codes #19327

Merged
merged 2 commits into from Jun 28, 2022
Merged

Try to handle incorrectly prefixed region codes #19327

merged 2 commits into from Jun 28, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 9, 2022

Description:

fixes #19323

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 9, 2022
@sgiehl sgiehl added this to the 4.12.0 milestone Jun 9, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 17, 2022
@sgiehl sgiehl requested a review from bx80 June 27, 2022 13:29
bx80
bx80 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the absence of any incorrectly prefixed GeoIP data I stepped through the new test with Xdebug to confirm that the prefix is removed. Since both the country code and hyphen must be matched for removal I can't think of any problematic edge cases 👍

@sgiehl sgiehl merged commit d1e15c2 into 4.x-dev Jun 28, 2022
@sgiehl sgiehl deleted the m19323 branch June 28, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

Attempt to handle incorrectly prefixed region codes
2 participants
@sgiehl @bx80