[UI] goal overview conversion rate not showing correct on the graph #19324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add reload after option change
update compute column
revert changes
peterhashair
added
Needs Review
added 2 commits
June 10, 2022 15:53
…s_requestedColumns__Goals.get_day.xml update tests
bx80
suggested changes
Jun 13, 2022
There was a problem hiding this comment.
It looks like the conversion rate isn't being formatted as a percent on the graph. Here is a goal with a 10.22% conversion rate (as per the sparkline).
When I click this goal on the goals overview screen the graph shows a 0.1% conversion rate
so the metric data is being loaded, but it's not formatted correctly.
|
@bx80 ah I couldn't reproduce that on mine, can you check if the sparkline for Feb 2022 matches the data. Maybe the date selector was on Feb, not Jan. |
|
@peterhashair, my mistake - formatting is working correctly after a cache refresh 👍 |
bx80
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #18766
The goal conversion rate is looking for
nb_visits_converted. that's not added in thegetDependentMetricscolumn. Add it back fixed it.Review