Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation file cleanups (refactor all html code, commands to type etc.) #1931

Closed
mattab opened this issue Jan 3, 2011 · 3 comments
Closed
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented Jan 3, 2011

Some language translations entries have

  • HTML (

    <a href=\'index.php\'>install Piwik now</a></b><br /><small> or &lt;a target="_blank" href="http://piwik.org/docs/setup-auto-archiving/">How to setup auto archiving page&lt;/a> )

    • command lines (
    • filenames eg. manifest.inc.php
    • function names eg. md5_file()
    • paths, eg. config/config.inc.php
    • PHP parameters eg. --with-zlib
    • or "install the php-libxml"
    • etc.

It would be nice to review all these and factor out these 'common' bits in a %s parameter each time. It is easy for translators to make a typo when copy pasting an HTML tag or an obscure PHP configure option.

This would allow greater quality in the Piwik translations.

@mattab mattab added this to the Future releases milestone Jul 8, 2014
@sgiehl sgiehl self-assigned this Sep 12, 2014
@mattab mattab modified the milestones: Long term, Mid term Dec 23, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@sgiehl
Copy link
Member

sgiehl commented Oct 3, 2018

Closing now. Most translations should already have been cleaned.

@sgiehl sgiehl closed this as completed Oct 3, 2018
@mattab
Copy link
Member Author

mattab commented Oct 17, 2018

fyi @sgiehl I found a few remaining, mostly searching for HTML elements ie. < and filenames ie. .php and --

3
2
remaining1

@mattab mattab reopened this Oct 17, 2018
@sgiehl
Copy link
Member

sgiehl commented Apr 28, 2020

Actually smaller portions of HTML are meanwhile greatly handled by transifex, so as long as the HTML isn't about to change often, there shouldn't be a reason to replace them with placeholders, as it's not possible in transifex to see their replacement. Will close this issue now and try to look through and clean up the translations from time to time if needed...

@sgiehl sgiehl closed this as completed Apr 28, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants