Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error due to non-array values #19309

Merged
merged 3 commits into from Jun 3, 2022
Merged

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Due to #18221 changes, we are getting a error "count(): Parameter must be an array or an object that implements Countable".
This was noticed in this build of GAImporter Plugin

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Jun 2, 2022
@AltamashShaikh AltamashShaikh added this to the 4.11.0 milestone Jun 2, 2022
@sgiehl sgiehl requested a review from bx80 June 2, 2022 14:33
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jun 2, 2022
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix look good 👍
(My original mistake for not checking all the possible return types of getNumeric 🙄 )

@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jun 3, 2022
@justinvelluppillai justinvelluppillai merged commit c6dc54b into 4.x-dev Jun 3, 2022
@justinvelluppillai justinvelluppillai deleted the 18221-fix-count-error branch June 3, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants