@ulcuber opened this Pull Request on June 2nd 2022 Contributor

Description:

Fixes regression of https://github.com/matomo-org/matomo/issues/6890
Same as https://github.com/matomo-org/matomo/commit/6130e7e86baff2979bb84bf979a13130124c1202

Review

@Findus23 commented on June 2nd 2022 Member

Hi,

Can you maybe explain a bit more why this change is needed? The linked PR and commit are nearly a decade old and we are currently more in the process of removing upgradephp (https://github.com/matomo-org/matomo/pull/16650)

@ulcuber commented on June 2nd 2022 Contributor

@Findus23 currently dump() does nothing because it is defined as empty function in libs/upgradephp/upgrade.php. That definition must come after original var-dumper autoloading (via require_once PIWIK_VENDOR_PATH . '/autoload.php';)

@ulcuber commented on June 2nd 2022 Contributor

@Findus23 we could move it in other place but I'm not sure where it should be

This Pull Request was closed on June 9th 2022
Powered by GitHub Issue Mirror