Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Annotations into their own dedicated table #19306

Open
samjf opened this issue Jun 2, 2022 · 3 comments
Open

Move Annotations into their own dedicated table #19306

samjf opened this issue Jun 2, 2022 · 3 comments
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Milestone
5.5.0

Comments

@samjf
Copy link
Contributor

samjf commented Jun 2, 2022

Move Annotations into their own table

At the moment annotations are saved in the Option table into a single row per site (see \Piwik\Plugins\Annotations\AnnotationList::save). This approach seems to cause DB performance problems when annotations are added in bulk due to constant serialization and locks for updating on a single row.

An approach to cleanly solve this problem would be to create a dedicated DB table for the annotations rather than the single row serialization. This would require a new model/schema and a migration of the current data, but would be a good way to future proof and solve this performance problem.

Your Environment

  • Matomo Version: 4.10.1
  • PHP Version: 8
  • Server Operating System: Mac
  • Additionally installed plugins:
@samjf samjf added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 2, 2022
@justinvelluppillai justinvelluppillai added the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Jun 2, 2022
@justinvelluppillai justinvelluppillai added this to the For Prioritization milestone Jun 3, 2022
@justinvelluppillai justinvelluppillai removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label Jun 3, 2022
@justinvelluppillai
Copy link
Contributor

I will move this to the For Prioritization queue. It is a pretty important issue to keep Cloud performant also.

@Chardonneaur
Copy link

Would it be possible to add it as a report in itself too? So that we could export it afterwards? For example as an email report.

@sgiehl
Copy link
Member

sgiehl commented Jun 27, 2022

@Chardonneaur In theory the would be possible. For that we need API methods to fetch those annotations and a report class to provide that. But not sure if that will be handled in this issue.

@justinvelluppillai justinvelluppillai added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. labels Aug 21, 2022
@mattab mattab added the Stability For issues that make Matomo more stable and reliable to run for sys admins. label Jan 16, 2024
@mattab mattab modified the milestones: For Prioritization, 5.5.0 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Stability For issues that make Matomo more stable and reliable to run for sys admins.
Projects
None yet
Milestone
5.5.0
Development

No branches or pull requests
5 participants
@mattab @justinvelluppillai @sgiehl @samjf @Chardonneaur