Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX regressions in global website settings #19303

Closed
sgiehl opened this issue Jun 1, 2022 · 3 comments · Fixed by #19375
Closed

UI/UX regressions in global website settings #19303

sgiehl opened this issue Jun 1, 2022 · 3 comments · Fixed by #19375
Assignees
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Jun 1, 2022

While developing another feature I came across some regressions in the global website settings form.
Might be possible they also exists in the general settings form:

  • When the API request to store the data returns an error (e.g. invalid excluded ip), the error is logged in the browser console and is displayed at the top of the form. But the loading bar above the save button remains and the save button stays disabled. That makes it impossible to simply fix the problem and save it again.

  • All text input areas behave a bit strange when you try to type some characters somewhere in between. If there is already text in the box and you try to type something e.g. in the front, the cursor will automatically jump to the end. This makes it hard to change anything.

@diosmosis I assume both are vue regressions. Could you check and fix them?

@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Jun 1, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone Jun 1, 2022
@diosmosis diosmosis self-assigned this Jun 1, 2022
@diosmosis
Copy link
Member

@sgiehl I can't reproduce the second issue, can you provide a browser/os and possibly a video?

@sgiehl
Copy link
Member Author

sgiehl commented Jun 21, 2022

@diosmosis sorry for the delay, that one somehow slipped through 🙈

I'm still able to reproduce the second one on locally on Windows using Chrome, Firefox or Edge but also on OSX / Chrome using BrowserStack.

screen-recording.mp4

@diosmosis
Copy link
Member

👍 I can reproduce now, and have a fix I'll put up soon.

@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants