@diosmosis opened this Pull Request on May 31st 2022 Member

Description:

The Vue code uses $.param() to stringify query params (primarily to handle nested arrays in URLs that some parts of matomo expect). This function uses '+' to encode spaces, which appears to cause some issues in other places of matomo. For example, in the Vue migration for UsersFlow, highlighting a page title w/ a space in it will display '+' in the popup title because '+' is sent as the rowLabel parameter (see the relevant PR for screenshots). The angularjs code constructs the URL w/ encodeURIComponent directly, which uses %20. This seems to work in the popup title.

Fixed in this PR by changing '+' to '%20' manually after constructing a query string.

Review

This Pull Request was closed on June 1st 2022
Powered by GitHub Issue Mirror