Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for undefined array index error when rendering sparklines. #19294

Merged
merged 1 commit into from May 31, 2022
Merged

Fix for undefined array index error when rendering sparklines. #19294

merged 1 commit into from May 31, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented May 31, 2022

Description:

Fixes #19275

Adds an array index check for the columnMetric array when formatting sparkline visualizations.

Review

@bx80 bx80 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 31, 2022
@bx80 bx80 added this to the 4.11.0 milestone May 31, 2022
@bx80 bx80 self-assigned this May 31, 2022
@sgiehl sgiehl merged commit 5ee8fb2 into 4.x-dev May 31, 2022
@sgiehl sgiehl deleted the m-19275-sparkline-undefined-index branch May 31, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@bx80 bx80

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Fix for undefined array index error when rendering sparklines
2 participants
@bx80 @sgiehl