Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests]fix css and UI PR 19286 #19289

Merged
merged 5 commits into from May 30, 2022
Merged

[Tests]fix css and UI PR 19286 #19289

merged 5 commits into from May 30, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

fix css and UI PR #19286.

Review

fix css
264553b 
fix css
@peterhashair peterhashair changed the title [CSS]fix css and UI PR 19286 [Tests]fix css and UI PR 19286 May 30, 2022
fix css
a7e51b5 
fix css
@peterhashair peterhashair mentioned this pull request May 30, 2022
Merged
11 tasks
Peter added 3 commits May 30, 2022 18:04
tide up some css
73b412f 
tide up some css
update tests ui
31b1bd1 
update tests ui
fix mobile ui
3b90958 
fix mobile ui
@peterhashair peterhashair merged commit 4603903 into 4.x-dev May 30, 2022
@peterhashair peterhashair deleted the fix-css branch May 30, 2022 08:04
@sgiehl sgiehl mentioned this pull request May 30, 2022
Merged
11 tasks
@sgiehl
Copy link
Member

sgiehl commented May 30, 2022

@peterhashair didn't you realize that your changes are now also showing the refresh button in the admin area? As the button actually doesn't work there at all, there is no sense in showing it.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 30, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 30, 2022
@sgiehl sgiehl mentioned this pull request May 30, 2022
Merged
11 tasks
@peterhashair
Copy link
Contributor Author

@sgiehl ops, sorry, was trying to fix the margin-right to 10px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhashair @sgiehl