Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] use explicit module since module in URL will be for the whole page, not just the main widget #19288

Merged
merged 1 commit into from May 30, 2022
Merged

[Vue] use explicit module since module in URL will be for the whole page, not just the main widget #19288

merged 1 commit into from May 30, 2022

Conversation

diosmosis
Copy link
Member

Description:

Fixes #19278

Review

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 30, 2022
@diosmosis diosmosis added this to the 4.11.0 milestone May 30, 2022
@diosmosis diosmosis mentioned this pull request May 30, 2022
Closed
@sgiehl sgiehl merged commit 59c2e64 into 4.x-dev May 30, 2022
@sgiehl sgiehl deleted the vue-marketplace-action-url branch May 30, 2022 09:43
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Can't install purchased plugins: Action 'installAllPaidPlugins' not found in the module 'CoreHome'
3 participants
@diosmosis @sgiehl @justinvelluppillai