Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Fix the database tooltip hidden problem #19285

Merged
merged 5 commits into from May 30, 2022
Merged

[UI] Fix the database tooltip hidden problem #19285

merged 5 commits into from May 30, 2022

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented May 29, 2022

Description:

Fixes: #19244

When the window reaches a certain size like a mobile, tablet when the.dataTableScroller applied overflow-x: scroll that hides the outside tooltip, same as when the page scroll down when the sticky table header reaches the top.

I changed the js when those happened, the tooltip shows below the header instead of above the header.

Review

@peterhashair peterhashair added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 29, 2022
@peterhashair peterhashair added this to the 4.11.0 milestone May 29, 2022
@peterhashair peterhashair added the Needs Review PRs that need a code review label May 30, 2022
@bx80
Copy link
Contributor

bx80 commented May 30, 2022

@peterhashair One thing I've noticed is if you scroll down so that the datatable header is only a couple of pixels away from the top of the viewport then the tooltip will still show at the top even though most of it cannot be seen. Perhaps there should be an offset in the calculation so if there is <25px(?) above the header then the tooltip is shown below?
image

@bx80
Copy link
Contributor

bx80 commented May 30, 2022

It would also be good to test this fix using Safari in case there is also an issue with the recent z-index header change.

@bx80 bx80 removed the Needs Review PRs that need a code review label May 30, 2022
@peterhashair
Copy link
Contributor Author

peterhashair commented May 30, 2022

@bx80 fixed it, just wondering if we could change the tooltip, and display it below the header as always, because, it's really hard to calculate the tooltip scrolling hidden point because the tooltip heigh is various. Test Safari works.

add scrolling points
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 100px offset seem to work well, it probably doesn't need to cover every possible tooltip size, just enough that the user can see where the tooltip is and scroll up or down to see it. 👍

The zen mode icon seems to have moved position after this change and it's changed a lot of the UI test screenshots. It might be worth seeing if that could be avoided or if not the screenshots will need to be updated.

@peterhashair
Copy link
Contributor Author

@bx80 that's coursed by another PR, Create fixes there #19289

Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I suppose both PRs will need to be merged at the same time then once those tests have completed successfully.

@peterhashair peterhashair merged commit c0159b4 into 4.x-dev May 30, 2022
@peterhashair peterhashair deleted the m19244 branch May 30, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Safari browser shows the information notice
2 participants