@peterhashair opened this Pull Request on May 29th 2022 Contributor

Description:

Fixes: #19244

When the window reaches a certain size like a mobile, tablet when the.dataTableScroller applied overflow-x: scroll that hides the outside tooltip, same as when the page scroll down when the sticky table header reaches the top.

I changed the js when those happened, the tooltip shows below the header instead of above the header.

Review

@bx80 commented on May 30th 2022 Contributor

@peterhashair One thing I've noticed is if you scroll down so that the datatable header is only a couple of pixels away from the top of the viewport then the tooltip will still show at the top even though most of it cannot be seen. Perhaps there should be an offset in the calculation so if there is <25px(?) above the header then the tooltip is shown below?
image

@bx80 commented on May 30th 2022 Contributor

It would also be good to test this fix using Safari in case there is also an issue with the recent z-index header change.

@peterhashair commented on May 30th 2022 Contributor

@bx80 fixed it, just wondering if we could change the tooltip, and display it below the header as always, because, it's really hard to calculate the tooltip scrolling hidden point because the tooltip heigh is various. Test Safari works.

@peterhashair commented on May 30th 2022 Contributor

@bx80 that's coursed by another PR, Create fixes there https://github.com/matomo-org/matomo/pull/19289

This Pull Request was closed on May 30th 2022
Powered by GitHub Issue Mirror