[CSS] add scroll to live visits table #19273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add scroll to live table
peterhashair
added
not-in-changelog
bx80
suggested changes
May 30, 2022
update tests
update tests
show full image
update tests
add timeout and screenshots
sgiehl
reviewed
Jun 1, 2022
added 2 commits
June 2, 2022 12:08
update scroll bar
update screenshot
|
I've bumped the UI tests to run again, just want to be sure that the Movers and Shakers widget overflow is a random test failure and not something else. |
|
The small screen dashboard UI test movers and shakers overflow is still failing each time on Travis but it passes when run locally, I've increase the delay from 250ms to 500ms to see if that fixes it. |
bx80
approved these changes
Jun 7, 2022
peterhashair
pushed a commit
that referenced
this pull request
Jun 16, 2022
* add scroll to live table add scroll to live table * add tests add tests * update tests update tests * update tests update tests * Update Dashboard_spec.js show full image * update tests update tests * add timeout and screenshots add timeout and screenshots * update scroll bar update scroll bar * update screenshot update screenshot * Rerun UI tests * Increase UI screenshot delay to fix random failure * update ui update ui Co-authored-by: sgiehl <stefan@matomo.org> Co-authored-by: Ben <ben.burgess@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #19254
add scroll to live table
Review