Include conversion attribution in visitor details #19269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvelluppillai
suggested changes
May 26, 2022
|
@justinvelluppillai as mentioned in the description. Those are tests from submodules. Would update them when the PR is approved to avoid spending time on updating the submodules on the PR unnecessarily. |
|
@justinvelluppillai shall we include that in 4.11? Guess seeing the attribution for conversions at least in API output might be helpful for some users. Or shall I directly update the PR so that information is also visible in the visits log. That should be doable in a couple of hours. |
sgiehl
added
the
c: APIs
sgiehl
force-pushed
the
conversionattribution
branch
from
ba38ee2
to
b323345
Compare
sgiehl
force-pushed
the
conversionattribution
branch
from
b323345
to
0aea65a
Compare
peterhashair
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Include conversion attribution in visitor details * updates expected test files * submodule updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This will include the referrer attribution details for conversions in the API response of
Live.getLastVisitsDetails.refs #18612
In a later step we could also consider to show that attribution in the visits log in the UI maybe.
Note the submodule tests will also need to be updated before merging this one.
ping @mattab
Review