Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] ignore linkSync errors in custom chai assertion to avoid error if expected file does not exist #19264

Merged
merged 1 commit into from May 27, 2022
Merged

[Vue] ignore linkSync errors in custom chai assertion to avoid error if expected file does not exist #19264

merged 1 commit into from May 27, 2022

Conversation

diosmosis
Copy link
Member

Description:

The error message in this PR is a bit easier to understand than the ENOENT error from node.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 24, 2022
@peterhashair peterhashair merged commit 229c9c4 into 4.x-dev May 27, 2022
@peterhashair peterhashair deleted the vue-ui-test-ignore-copy-failure branch May 27, 2022 00:01
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @justinvelluppillai