Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default null/falsey value in FieldNumber to 0 to match previous behavior #19262

Merged
merged 1 commit into from May 25, 2022
Merged

Set default null/falsey value in FieldNumber to 0 to match previous behavior #19262

merged 1 commit into from May 25, 2022

Conversation

diosmosis
Copy link
Member

Description:

Noticed that the goal default revenue stopped being 0 since angularjs' ng-model is no longer used. Fixed by this PR.

Review

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 24, 2022
@diosmosis diosmosis added this to the 4.10.1 milestone May 24, 2022
@justinvelluppillai justinvelluppillai merged commit efa9b51 into next_release May 25, 2022
@justinvelluppillai justinvelluppillai deleted the vue-number-default-zero branch May 25, 2022 00:07
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 25, 2022
@justinvelluppillai justinvelluppillai changed the title [Vue] default null/falsey value in FieldNumber to 0 to match angularjs behavior Set default null/falsey value in FieldNumber to 0 to match previous behavior May 25, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai