feat: adds a refresh button #19261
Merged
feat: adds a refresh button #19261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit introduces a refresh button to every page in the CoreHome module. When the user clicks the button, the data of the current page is refreshed without reloading the page. Refs matomo-org#11047
There was a problem hiding this comment.
should we use reload icon, I believe other places are using that one, a couple of test screenshots needs to be updated which I can do, plugins/CoreHome/lang/en.json should be reverted, it does translate automatically by the system but other than that looks good.
|
@justinvelluppillai I feels like this one is good to merge, I will fix the UI tests and lang in another PR. |
|
Sounds good @peterhashair - you can go ahead and do that. It might be better to create a branch off this branch and fix the UI tests and remove the de translation before merging if you know how. |
|
@justinvelluppillai sounds good. |
11 tasks
peterhashair
pushed a commit
that referenced
this pull request
May 30, 2022
* feat: adds a refresh button this commit introduces a refresh button to every page in the CoreHome module. When the user clicks the button, the data of the current page is refreshed without reloading the page. Refs #11047 * Update _headerMessage.twig update icon and some css * revert de lang revert de lang * update screenshots update screenshots * update screenshots update screenshots Co-authored-by: Andre <aeckardt@outlook.com>
sgiehl
reviewed
May 30, 2022
This was referenced May 30, 2022
justinvelluppillai
added
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
this commit introduces a refresh button to every page in the CoreHome module. When the user clicks the button, the data of the current page is refreshed without reloading the page.
I've added a shortcut. So if this PR makes it into production, i think the documentation needs to be upgraded at https://matomo.org/faq/how-to/faq_24340/
Refs #11047
Screencast_from_05-24-2022_09.01.27_PM.mp4
Review