Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] correct sparkline segment encoding #19260

Merged

Conversation

diosmosis
Copy link
Member

Description:

Fixes #19209

AjaxHelper.mixinDefaultGetParams() has legacy logic that does uses the encoded segment query parameter value, but MatomoUrl.stringify() assumes all values are decoded. This causes the segment to be double encoded in segment URLs.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 24, 2022
@diosmosis diosmosis added this to the 4.10.1 milestone May 24, 2022
@justinvelluppillai justinvelluppillai merged commit 023676b into next_release May 25, 2022
@justinvelluppillai justinvelluppillai deleted the vue-correct-sparkline-segment-encoding branch May 25, 2022 00:39
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 25, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants