Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] reset dom element state in fields before update:modelValue #19259

Merged
merged 1 commit into from May 26, 2022

Conversation

diosmosis
Copy link
Member

Description:

…so parent component can decide if change should go through. I meant for this change to be in #19236, but I guess I forgot to push it.

Changes:

  • Make sure DOM state is reset for fields that need it before emitting update:modelValue, so parent components can ignore the change if they want.

Review

…component can decide if change should go through
@diosmosis diosmosis added the Needs Review PRs that need a code review label May 24, 2022
@diosmosis diosmosis added this to the 4.11.0 milestone May 24, 2022
@diosmosis diosmosis merged commit 13ab978 into 4.x-dev May 26, 2022
@diosmosis diosmosis deleted the vue-field-allow-cancel-set branch May 26, 2022 16:55
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants