format timestamp as date to make it more easy to read in systemCheckPage #19256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeschiren
changed the title
justinvelluppillai
added
Needs Review
sgiehl
reviewed
May 23, 2022
Comment on lines
+45
to
+46
| $results[] = DiagnosticResult::informationalResult('Archive Time Last Started', date("Y-m-d H:i:s", Option::get(CronArchive::OPTION_ARCHIVING_STARTED_TS))); | ||
| $results[] = DiagnosticResult::informationalResult('Archive Time Last Finished', date("Y-m-d H:i:s", Option::get(CronArchive::OPTION_ARCHIVING_FINISHED_TS))); |
There was a problem hiding this comment.
For a new installation where the archiving might have never been started or finished, the option values might not exist. In that case I guess 1970-01-01 01:00:00 would be displayed. We could maybe simply output a - for that case (e.g. if the Option::get returns false).
There was a problem hiding this comment.
Adding a suggestion to make it easier to implement @sgiehl's solution - @mikkeschiren can you please review and commit this change if satisfied? Then we can merge this PR I think.
Suggested change
| $results[] = DiagnosticResult::informationalResult('Archive Time Last Started', date("Y-m-d H:i:s", Option::get(CronArchive::OPTION_ARCHIVING_STARTED_TS))); | |
| $results[] = DiagnosticResult::informationalResult('Archive Time Last Finished', date("Y-m-d H:i:s", Option::get(CronArchive::OPTION_ARCHIVING_FINISHED_TS))); | |
| $archive_start = Option::get(CronArchive::OPTION_ARCHIVING_STARTED_TS); | |
| $results[] = DiagnosticResult::informationalResult('Archive Time Last Started', ($archive_start ? date("Y-m-d H:i:s", $archive_start) : '-')); | |
| $archive_end = Option::get(CronArchive::OPTION_ARCHIVING_FINISHED_TS); | |
| $results[] = DiagnosticResult::informationalResult('Archive Time Last Finished', ($archive_end ? date("Y-m-d H:i:s", $archive_end) : '-')); |
sgiehl
added
Waiting for user feedback
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
justinvelluppillai
removed
the
Stale
|
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
github-actions
bot
added
the
Stale
|
Closing this PR. I'll cherry-pick and adjust the changes directly to 4.x-dev. |
sgiehl
removed
Waiting for user feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make it easier to read and understand when latest archiving was done.
Review