Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] Allow other primitive types as arguments to translate. #19255

Merged
merged 1 commit into from May 23, 2022
Merged

[Vue] Allow other primitive types as arguments to translate. #19255

merged 1 commit into from May 23, 2022

Conversation

diosmosis
Copy link
Member

Description:

Numbers and booleans can be used in _pk_translate so it makes sense to allow them in translate().

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 22, 2022
@diosmosis diosmosis added this to the 4.11.0 milestone May 22, 2022
@diosmosis diosmosis merged commit de79ff0 into 4.x-dev May 23, 2022
@diosmosis diosmosis deleted the vue-translate-input-types branch May 23, 2022 00:12
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @justinvelluppillai