Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 429 (rate limited) response code #19245

Merged
merged 3 commits into from May 24, 2022
Merged

Add 429 (rate limited) response code #19245

merged 3 commits into from May 24, 2022

Conversation

JasonMortonNZ
Copy link
Contributor

@JasonMortonNZ JasonMortonNZ commented May 19, 2022

Description:

This PR adds a 429 response code to Common::sendResponseCode(). and wraps the Zend_Db_Table::setDefaultAdapter($adapter); in a conditional This helps prevent a reference being kept, making it easier to close a DB connection if required.

Review

@JasonMortonNZ JasonMortonNZ added the Needs Review PRs that need a code review label May 19, 2022
core/Db/Adapter.php Outdated Show resolved Hide resolved
@justinvelluppillai justinvelluppillai merged commit 53c00a7 into 4.x-dev May 24, 2022
@justinvelluppillai justinvelluppillai deleted the dev-2437 branch May 24, 2022 21:13
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 24, 2022
@justinvelluppillai justinvelluppillai changed the title Add 429 response code & conditional setDefaultAdapter Add 429 response code May 24, 2022
@justinvelluppillai justinvelluppillai changed the title Add 429 response code Add 429 (rate limited) response code Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants