Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default hasExtraPlugin in campaign builder component to true #19241

Merged
merged 1 commit into from May 23, 2022
Merged

Set default hasExtraPlugin in campaign builder component to true #19241

merged 1 commit into from May 23, 2022

Conversation

diosmosis
Copy link
Member

Description:

Did a quick check and found that the hasExtraPlugin property in the CampaignBuilder component has an incorrect default value compared to 4.5.0 code. Fixed in this PR.

Review

@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 18, 2022
@diosmosis diosmosis added this to the 4.10.1 milestone May 18, 2022
@justinvelluppillai justinvelluppillai merged commit dfed579 into next_release May 23, 2022
@justinvelluppillai justinvelluppillai deleted the vue-campaign-builder-default branch May 23, 2022 03:33
@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 25, 2022
@justinvelluppillai justinvelluppillai changed the title [Vue] hasExtraPlugin in campaign builder component should default to true Set default hasExtraPlugin in campaign builder component should to true May 25, 2022
@justinvelluppillai justinvelluppillai changed the title Set default hasExtraPlugin in campaign builder component should to true Set default hasExtraPlugin in campaign builder component to true May 25, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @justinvelluppillai