Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] idsite property in SegmentGenerator component must default to Matomo idSite #19240

Merged
merged 1 commit into from May 21, 2022
Merged

[Vue] idsite property in SegmentGenerator component must default to Matomo idSite #19240

merged 1 commit into from May 21, 2022

Conversation

diosmosis
Copy link
Member

Description:

Fixes #19237

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 18, 2022
@diosmosis diosmosis added this to the 4.10.1 milestone May 18, 2022
@diosmosis diosmosis mentioned this pull request May 18, 2022
Closed
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 18, 2022
@sgiehl
Copy link
Member

sgiehl commented May 20, 2022

@justinvelluppillai any plans for releasing 4.10.1? Or shall we put this into 4.11.0 as it might be released soon anyway?

@justinvelluppillai
Copy link
Contributor

I'm planning on a 4.10.1 release early next week, there are currently around 3 regressions to patch there.

@sgiehl sgiehl merged commit e28c933 into next_release May 21, 2022
@sgiehl sgiehl deleted the 19237-vue-custom-dim-segment branch May 21, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.10.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @sgiehl @justinvelluppillai @peterhashair