Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] change modal callbacks option type to allow any key value #19238

Merged
merged 1 commit into from May 20, 2022
Merged

[Vue] change modal callbacks option type to allow any key value #19238

merged 1 commit into from May 20, 2022

Conversation

diosmosis
Copy link
Member

Description:

For modalConfirm(), the callback key names can be any value that matches an <input>'s role attribute. It's not limited to yes,no,validation. This PR allows any key to be specified in TypeScript.

Review

@diosmosis
modal callabacks are not limited to a specific set of keys, but can b…
47bd640 
…e any string that matches an inputs role attribute value
@diosmosis diosmosis added the Needs Review PRs that need a code review label May 18, 2022
@diosmosis diosmosis added this to the 4.11.0 milestone May 18, 2022
@sgiehl sgiehl merged commit 6eb8937 into 4.x-dev May 20, 2022
@sgiehl sgiehl deleted the vue-modal-callbacks-type branch May 20, 2022 14:24
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@diosmosis @peterhashair @justinvelluppillai @sgiehl