New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 429 response code within UI #19233
Comments
I will add this to the current milestone as it is a dependency for improving rate limiting on Cloud |
I am not too sure if I am on the right track here. I think to prepend this before the line. Would that works? // load rate limit page if status code 429
if (http_response_code() === 429) {
$view = new view('@API/rateLimit');
return $view->render();
} matomo/plugins/API/Controller.php Line 56 in 3f9a00f |
I was expecting more likely something in |
@JasonMortonNZ just a question on the UI changes, currently the UI shows this error message for the API endpoints
I suggest using option 2. I can use this text there. |
I would suggest to maybe not directly implement any screen or custom message in Matomo itself, as it's quite cloud related only. |
This would be ideal @peterhashair . We would want to handle the 429 error directly in core and then show a message. However, the message will need to be different so it works for regular On-Premise users too. The Cloud team will then maybe want to overwrite the message/translation.
The idea was to have this in core so that other On-Premise users can benefit from this as well as some would already have some rate limiting configured and as always we would then ideally also document this behaviour in an FAQ so making it more clear when others set it up in the future. |
At present if a 429 response is returned from an API request the UI would show a generic error message. We would like to provide a more specific custom error message for this response code, indicating the user has sent too many requests in a given amount of time.
This is required to complete the rate limiting feature (dev-2437) on cloud and will improve uptime, cloud performance and customer experience.
The text was updated successfully, but these errors were encountered: