Take care to always 'return request' in appendAvailablePerformanceMetrics #19232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rics This alleviates a variety of spurious "Invalid idSite: 0" issues as described in matomo-org#12264. That issue was closed in 2019 but since then many of us have continued to see issues that do not seem to be rooted in client configuration errors, as suggested by matomo-org#12264 (comment).
Closed
|
Hi @danielpunkass |
|
@sgiehl I followed the instructions but the diff seemed a bit bigger than I expected. Let me know if the pushed .min.js files seems OK to you. FWIW I am on a Mac and I saw that it's technically unsupported. If it's a problem I can probably redo it from a Linux box. |
|
@danielpunkass Looks all good. But seems someone else commited the Thanks again for your contribution! This will be included in Matomo 4.11. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alleviates a variety of spurious "Invalid idSite: 0" issues as described in #12264. That issue was closed in 2019 but since then many of us have continued to see issues that do not seem to be rooted in client configuration errors, as suggested by #12264 (comment).