Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure goal sparklines show the correct goal #19226

Merged
merged 1 commit into from May 17, 2022
Merged

Ensure goal sparklines show the correct goal #19226

merged 1 commit into from May 17, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 16, 2022

Description:

It seems the idGoal parameter got lost for the sparklines. Or maybe it never worked....

fixes #19206

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 16, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 16, 2022
@sgiehl
Copy link
Member Author

sgiehl commented May 16, 2022

Seems all related tests are still passing. That actually indicates that our UI tests are not that good. At some point we maybe should consider creating a new & bigger dataset for our UI tests, so there is also some historical data, that can be shown in the sparklines.
But doing that might be a bit out of scope for this fix. Guess we should keep that in mind for Matomo 5 maybe.

@sgiehl sgiehl marked this pull request as ready for review May 16, 2022 18:42
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 16, 2022
bx80
bx80 approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, on 4.x-dev sparklines the same for every goal, with this PR each goals shows it's own sparkline 👍

@sgiehl sgiehl merged commit f491565 into 4.x-dev May 17, 2022
@sgiehl sgiehl deleted the m19206 branch May 17, 2022 08:43
@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Sparklines show correct data in all goals reports
2 participants
@sgiehl @bx80