Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in "Visits in Real-time" widget when visits log and profile is disabled #19219

Closed
tsteur opened this issue May 16, 2022 · 4 comments
Closed

Error in "Visits in Real-time" widget when visits log and profile is disabled #19219

tsteur opened this issue May 16, 2022 · 4 comments
Labels
worksforme The issue cannot be reproduced and things work as intended.

Comments

@tsteur
Copy link
Member

tsteur commented May 16, 2022

I have the visits log & profile disabled in the site:

image

In a dashboard I have the "Visits in Real-time" widget.

This shows below error

image

Expected:

Show a nice error message saying this visitor is disabled and that an admin can enable it.

Background

This is the request that fails
image

The response includes the correct message. But Matomo doesn't show it and instead replaces it with a generic one
image
@tsteur tsteur added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. c: Privacy For issues that impact or improve the privacy. labels May 16, 2022
@sgiehl
Copy link
Member

sgiehl commented May 16, 2022

@tsteur Shouldn't we simply disable the widget if visits log & profile are disabled?

@tsteur
Copy link
Member Author

tsteur commented May 16, 2022

@sgiehl disable the widget when the feature is disabled for a site would work too 👍

@sgiehl
Copy link
Member

sgiehl commented May 17, 2022

Actually it seems the widget should already be disabled if the visits log was disabled. Just tested that locally and the widget isn't shown anymore, even if it was added to the dashboard before. It for sure might fail if a dashboard is opened and you disable the visits log in another tab.

@tsteur
Copy link
Member Author

tsteur commented May 18, 2022

👍 I'll close it again as I now can't reproduce it either. Maybe some caching or so. It's been disabled for days though and I had reloaded the page a few times and the error still showed up. I'll re-open if I see the error again.

@tsteur tsteur closed this as completed May 18, 2022
@tsteur tsteur added worksforme The issue cannot be reproduced and things work as intended. and removed c: Privacy For issues that impact or improve the privacy. Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @sgiehl