[Vue] correctly destroy vue entry components in widgetloader #19216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
May 15, 2022
There was a problem hiding this comment.
The changes imho look fine. I'll leave it up to @justinvelluppillai if this will go into 4.10. or not.
justinvelluppillai
added a commit
that referenced
this pull request
May 16, 2022
* tweak QueryParameters type in index.d.ts to better match arbitrary object types (#19191) * tweak QueryParameters type in index.d.ts to better match arbitrary object types * make sure github action takes into account changes in CoreVue types * add ability to use a deep watch in scope var watches in angularjs adapters (#19195) * covert getPluginUmdChunks from private to protected (#19212) * set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge * protected getPluginUmdChunks update private to protect * correctly destroy vue entry components in widgetloader (#19216) * Release Matomo 4.10.0 Co-authored-by: dizzy <diosmosis@users.noreply.github.com> Co-authored-by: Peter Zhang <peter@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The code used to destroy existing content before it gets replaced in WidgetLoader did not destroy vue components, so effects like watches/computed properties might not be cleaned up properly when switching widgets. Fixed by this PR.
Not sure if this can go into 4.10, but it would be good for it to if possible.
CC @justinvelluppillai
Review