New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
covert getPluginUmdChunks from private to protected #19212
Conversation
* Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge
Sorry @peterhashair I meant to do this on the |
@justinvelluppillai sorry, my bad. |
update private to protect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterhashair the changes look good now. Can you please just confirm the failing tests are failing for unrelated reasons before merging?
@justinvelluppillai I look the failed tests, 4 are random, 1 is about SEO ranking. all unrelated. |
* tweak QueryParameters type in index.d.ts to better match arbitrary object types (#19191) * tweak QueryParameters type in index.d.ts to better match arbitrary object types * make sure github action takes into account changes in CoreVue types * add ability to use a deep watch in scope var watches in angularjs adapters (#19195) * covert getPluginUmdChunks from private to protected (#19212) * set default color value, when key not exist. (#18696) * Update Sparkline.php add addition setup * Update Sparkline.php update foreach to array_merge * protected getPluginUmdChunks update private to protect * correctly destroy vue entry components in widgetloader (#19216) * Release Matomo 4.10.0 Co-authored-by: dizzy <diosmosis@users.noreply.github.com> Co-authored-by: Peter Zhang <peter@innocraft.com>
Description:
Fixes: #19207
covert getPluginUmdChunks from private to protected.
Review