Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spark lines show correctly in KPI widget when using segments #19209

Closed
jmumby opened this issue May 11, 2022 · 6 comments
Closed

Spark lines show correctly in KPI widget when using segments #19209

jmumby opened this issue May 11, 2022 · 6 comments
Assignees
@diosmosis
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.10.1

Comments

@jmumby
Copy link

jmumby commented May 11, 2022

When you use KPI widgets in the dashboard and select for example Visits and then apply a segment the spark line flat lines.

image

Expected Behavior

The spark line should appear the same way it does for all visits.

image

Current Behavior

The spark line is missing.

Steps to Reproduce (for Bugs)

  1. Add the KPI widget to your dashboard
  2. Select a metric like Visits
  3. Apply a segment

Your Environment

Matomo Cloud 11/MAY/22
@jmumby jmumby added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 11, 2022
@sgiehl
Copy link
Member

sgiehl commented May 15, 2022

This might possibly be a url encoding issue. If e.g. the segment might be encoded too often or less in the url, it might fail to load.
Not sure if there were any changes when migrating to vue maybe. Guess we should quickly check that (with browser archiving disabled).

@sgiehl sgiehl added the Needs priority decision This issue may need to be added to the current milestone by Product Manager label May 15, 2022
@justinvelluppillai
Copy link
Contributor

It'd be good to confirm whether this is a regression @sgiehl and if so we can prioritise it for the next patch release or 4.11.0

@justinvelluppillai justinvelluppillai removed the Needs priority decision This issue may need to be added to the current milestone by Product Manager label May 24, 2022
@sgiehl
Copy link
Member

sgiehl commented May 24, 2022

@justinvelluppillai This actually seems to be a vue regression. With Matomo 4.6. a segment like deviceType==tablet was included in the sparkline url with deviceType%3D%3Dtablet, with latest 4.x-dev it's included with deviceType%253D%253Dtablet. So it now seems encoded twice. ping @diosmosis

@sgiehl sgiehl added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 24, 2022
@sgiehl sgiehl added this to the 4.10.1 milestone May 24, 2022
@heurteph-ei
Copy link

@justinvelluppillai it was working on 4.3.1:
image

@diosmosis diosmosis self-assigned this May 24, 2022
@diosmosis diosmosis mentioned this issue May 24, 2022
Merged
11 tasks
@diosmosis
Copy link
Member

@sgiehl I was not able to reproduce the original problem locally, but I was able to see the double encoded segment. The fix for that is here: #19260. Can you check if it solves the original problem?

@justinvelluppillai
Copy link
Contributor

thanks @sgiehl and @diosmosis

@justinvelluppillai justinvelluppillai changed the title Spark lines are missing from KPI widget when using segments Spark lines show correctly in KPI widget when using segments May 25, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.10.1
Development

No branches or pull requests
5 participants
@diosmosis @justinvelluppillai @sgiehl @jmumby @heurteph-ei