Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI error when deploying matomo 4.9.1 on wordpress #19207

Closed
mattmary opened this issue May 11, 2022 · 4 comments · Fixed by #19212
Closed

UI error when deploying matomo 4.9.1 on wordpress #19207

mattmary opened this issue May 11, 2022 · 4 comments · Fixed by #19212
Assignees
@peterhashair
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.10.0

Comments

@mattmary
Copy link
Contributor

Expected Behavior

Be able to open matomo 4.9.1 on wordpress

Current Behavior

Only a part of the interface is displayed. there is a js error
Screenshot from 2022-04-20 11-14-49

Possible Solution

removing the method getJsInclusionDirective in the plugins/WordPress/WpAssetManager.php file solves the issue.
@mattmary mattmary added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 11, 2022
@mattmary mattmary mentioned this issue May 11, 2022
Closed
@justinvelluppillai justinvelluppillai added Regression Indicates a feature used to work in a certain way but it no longer does even though it should. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 11, 2022
@justinvelluppillai justinvelluppillai added this to the 4.10.0 milestone May 11, 2022
@mattmary
Copy link
Contributor Author

matomo-org/matomo-for-wordpress#605

@peterhashair
Copy link
Contributor

peterhashair commented May 11, 2022 •
edited

@mattmary @justinvelluppillai
I fixed it by remove /plugins/WordPress/WpAssetManager.php

replace below with

use Piwik\AssetManager; 
...
$assetManager = new AssetManager();

https://github.com/matomo-org/matomo-for-wordpress/blob/3665e6fad628d16fea27e3f2672f571e5a82b1c1/plugins/WordPress/WordPress.php#L139

PR here matomo-org/matomo-for-wordpress#607

@mattmary
Copy link
Contributor Author

the wordpress asset manager does not load the new js files.
to be able to do it, I need access to the assetManager::getPluginUmdChunks from the wpAssetManager. Can you switch its visibility to protected?

@justinvelluppillai
Copy link
Contributor

Most of the changes needed here are in the WpAssetManager, but @peterhashair can you please change AssetManager::getPluginUmdChunks from private to protected? We can merge this change to 4.10.0 before release, on next_release branch.

@peterhashair peterhashair mentioned this issue May 11, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterhashair peterhashair

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging a pull request may close this issue.

covert getPluginUmdChunks from private to protected matomo-org/matomo
3 participants
@justinvelluppillai @peterhashair @mattmary