Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparklines show correct data in all goals reports #19206

Closed
mattab opened this issue May 10, 2022 · 1 comment · Fixed by #19226
Closed

Sparklines show correct data in all goals reports #19206

mattab opened this issue May 10, 2022 · 1 comment · Fixed by #19226
Assignees
@sgiehl
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.11.0

Comments

@mattab
Copy link
Member

mattab commented May 10, 2022

in the Goals report the sparklines for each goal are all the same although they should be different.

For example here: https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=month&date=today#?idSite=1&period=month&date=today&category=Goals_Goals&subcategory=General_Overview

Expected Behavior

The sparklines should be different and show the real data.

Current Behavior

Sparklines in Goals Overview are all the same but shouldn't be.

This seems to be buggy only in Goal overview report. (Other sparklines seem to work fine?)

Proposed solution

Is there a UI test to catch this regression in the future?

Your Environment

Reproduced in 4.9.1 and still present in latest RC
@mattab mattab added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 10, 2022
@justinvelluppillai justinvelluppillai added this to the 4.11.0 milestone May 11, 2022
@sgiehl
Copy link
Member

sgiehl commented May 16, 2022

Guess that one regressed in #18493

@sgiehl sgiehl self-assigned this May 16, 2022
@sgiehl sgiehl mentioned this issue May 16, 2022
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title Sparklines show wrong data in all goals reports Sparklines show correct data in all goals reports Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Ensure goal sparklines show the correct goal matomo-org/matomo
3 participants
@mattab @justinvelluppillai @sgiehl