Handle write permission correctly when checking for users with access to same site #19199
Conversation
sgiehl
added
not-in-changelog
There was a problem hiding this comment.
While these changes seem sensible I can't reproduce the original issue so it's not possible to confirm this actually fixes the issue. @sgiehl did you manage to reproduce the issue? The original comment says the user was Admin and couldn't copy the dashboard to a View user, so I'm not sure if this solves that.
|
@justinvelluppillai I wasn't able to reproduce with view permission. But guess the users that weren't visible had |
|
@justinvelluppillai did you do a code review on this one? If so, guess we can merge it, as it should at least fix an issue for users with write permission. |
There was a problem hiding this comment.
I will approve this on the basis it fixes a potential bug. I've pinged @Starker3 internally to see if it fixes the issue he originally reported also.
|
It definitely fixes a bug. I could reproduce the problem with write permission. Will merge it. |
Description:
fixes #18692
Review