Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak QueryParameters type in index.d.ts to better match arbitrary object types #19191

Merged
merged 2 commits into from May 8, 2022
Merged

tweak QueryParameters type in index.d.ts to better match arbitrary object types #19191

merged 2 commits into from May 8, 2022

Conversation

diosmosis
Copy link
Member

Description:

This avoids typescript errors when casting certain arbitrary objects to the QueryParameters type. I was specifically having trouble with this one:

{
  example: string;
  name: string;
  types: {
    name: string;
    value: string;
  }[];
  value: string;
}[]

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 6, 2022
@diosmosis diosmosis added this to the 4.11.0 milestone May 6, 2022
@sgiehl sgiehl merged commit 5e51661 into 4.x-dev May 8, 2022
@sgiehl sgiehl deleted the vue-query-params-type-tweak branch May 8, 2022 17:21
@sgiehl sgiehl modified the milestones: 4.11.0, 4.10.0 May 9, 2022
sgiehl pushed a commit that referenced this pull request May 9, 2022
@diosmosis @sgiehl
tweak QueryParameters type in index.d.ts to better match arbitrary ob…
333af8b 
…ject types (#19191)

* tweak QueryParameters type in index.d.ts to better match arbitrary object types

* make sure github action takes into account changes in CoreVue types
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 9, 2022
justinvelluppillai added a commit that referenced this pull request May 16, 2022
@justinvelluppillai @diosmosis
Merge 4.10.0 changes back to development branch (#19223)
7d6d2bc 
* tweak QueryParameters type in index.d.ts to better match arbitrary object types (#19191)

* tweak QueryParameters type in index.d.ts to better match arbitrary object types

* make sure github action takes into account changes in CoreVue types

* add ability to use a deep watch in scope var watches in angularjs adapters (#19195)

* covert getPluginUmdChunks from private to protected (#19212)

* set default color value, when key not exist. (#18696)

* Update Sparkline.php

add addition setup

* Update Sparkline.php

update foreach to array_merge

* protected getPluginUmdChunks

update private to protect

* correctly destroy vue entry components in widgetloader (#19216)

* Release Matomo 4.10.0

Co-authored-by: dizzy <diosmosis@users.noreply.github.com>
Co-authored-by: Peter Zhang <peter@innocraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl