Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isObjectEmpty function in piwik.js #19182

Merged
merged 2 commits into from May 5, 2022
Merged

Improve isObjectEmpty function in piwik.js #19182

merged 2 commits into from May 5, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 5, 2022

Description:

fixes #19181

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 5, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 5, 2022
@justinvelluppillai justinvelluppillai merged commit 351307d into 4.x-dev May 5, 2022
@justinvelluppillai justinvelluppillai deleted the m19181 branch May 5, 2022 22:19
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Unnecessary loop
2 participants
@sgiehl @justinvelluppillai