Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary loop #19181

Closed
ulcuber opened this issue May 5, 2022 · 1 comment · Fixed by #19182
Closed

Unnecessary loop #19181

ulcuber opened this issue May 5, 2022 · 1 comment · Fixed by #19182
Assignees
@sgiehl
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone
4.11.0

Comments

@ulcuber
Copy link
Contributor

ulcuber commented May 5, 2022

Expected Behavior

Current Behavior

matomo/js/piwik.js

Line 266 in 0e41d7e

isEmpty = false;

Possible Solution

return false immediate

Steps to Reproduce (for Bugs)

Context

Your Environment

  • Matomo Version:
  • PHP Version:
  • Server Operating System:
  • Additionally installed plugins:
  • Browser:
  • Operating System:
@ulcuber ulcuber added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 5, 2022
@sgiehl
Copy link
Member

sgiehl commented May 5, 2022

Hi @ulcuber
Thanks for point that out. You are right, that can be improved. I'll try to set up a PR for that quickly.

@sgiehl sgiehl self-assigned this May 5, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 5, 2022
@sgiehl sgiehl added c: Performance For when we could improve the performance / speed of Matomo. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 5, 2022
@sgiehl sgiehl mentioned this issue May 5, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Improve isObjectEmpty function in piwik.js matomo-org/matomo
2 participants
@sgiehl @ulcuber