Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSites: move getAllWithGroups method from Controller to API #19180

Merged
merged 4 commits into from May 17, 2022
Merged

MultiSites: move getAllWithGroups method from Controller to API #19180

merged 4 commits into from May 17, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 5, 2022

Description:

Having that method in Controller actually only had disadvantages for the loading speed, as a normal request is processed. An API request skips stuff like checking if the browser is allowed, closes the session very early, ...

refs L3-241

Review

@sgiehl sgiehl added this to the 4.11.0 milestone May 5, 2022
@sgiehl sgiehl added the c: Performance For when we could improve the performance / speed of Matomo. label May 5, 2022
@sgiehl sgiehl marked this pull request as ready for review May 5, 2022 11:38
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 5, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label May 13, 2022
bx80
bx80 approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Tested UI and did some breakpoint checks.

@sgiehl sgiehl removed Needs Review PRs that need a code review Stale The label used by the Close Stale Issues action labels May 17, 2022
@sgiehl sgiehl merged commit 0acc687 into 4.x-dev May 17, 2022
@sgiehl sgiehl deleted the multisites branch May 17, 2022 08:46
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
c: Performance For when we could improve the performance / speed of Matomo. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @bx80 @justinvelluppillai