Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid request to API.getPagesComparisonsDisabledFor in TagManager #19179

Merged
merged 3 commits into from May 6, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 5, 2022

Description:

fixes matomo-org/tag-manager#478

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 5, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 5, 2022
@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 5, 2022
@sgiehl
Copy link
Member Author

sgiehl commented May 5, 2022

@AltamashShaikh I've pushed a fix. Let me know if it works that way or if you need further assistance.

@AltamashShaikh
Copy link
Contributor

@sgiehl It works as expected 👍

@sgiehl sgiehl merged commit 2bbf7f4 into 4.x-dev May 6, 2022
@sgiehl sgiehl deleted the tagmanagercomparison branch May 6, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag Manager preview is causing a failed HTTP request API.getPagesComparisonsDisabledFor
2 participants