Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of calculating evolution trend metric value #19172

Merged
merged 1 commit into from May 5, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 4, 2022

Description:

This will avoid calling Metrics::isLowerValueBetter each time the trend value for a row is calculated, which can be easily hundreds or thousands of calls depending on the datatable size.

refs L3-241

Review

@sgiehl sgiehl added c: Performance For when we could improve the performance / speed of Matomo. Needs Review PRs that need a code review labels May 4, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 4, 2022
@peterhashair peterhashair merged commit 4c7a49e into 4.x-dev May 5, 2022
@peterhashair peterhashair deleted the performanceimpr branch May 5, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants