Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Fix vue-directive selector, make sure to select root node if it has vue-directive, not vue-entry #19165

Merged
merged 1 commit into from May 2, 2022

Conversation

diosmosis
Copy link
Member

Description:

As title. Can cause problems when vue-entry is used within a widget.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 2, 2022
@diosmosis diosmosis added this to the 4.10.0 milestone May 2, 2022
@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label May 2, 2022
@diosmosis diosmosis merged commit 66d3116 into 4.x-dev May 2, 2022
@diosmosis diosmosis deleted the vue-directive-selector-fix branch May 2, 2022 23:59
@justinvelluppillai justinvelluppillai added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants