New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Widgetize page translatable #19157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @korve
Thanks for creating this pull request. Very appreciated!
I left a couple of comments, would be awesome if you could apply the changes, so this one could go into the upcoming release.
plugins/Widgetize/vue/src/WidgetPreview/WidgetPreviewIframe.vue
Outdated
Show resolved
Hide resolved
plugins/Widgetize/vue/src/WidgetPreview/WidgetPreviewIframe.vue
Outdated
Show resolved
Hide resolved
Thanks for the Review! Very insightful :) I have a question. The link to the Security Settings page is not working for me locally. The affected code is here:
The generated URL is Is this a problem with my host settings or is it a problem with my changes? |
@korve seems that was actually already broken before. There is a typo in the linkTo method. It needs to be
So the three dots before params are missing. Adding them should fix the issue I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 🎉
I'll update the tests & vue files after merging it... |
Description:
This PR makes the Widgetize page translatable. The related issue is #19076
Review