Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate piwik.js/matomo.js to Typescript #19144

Open
Findus23 opened this issue Apr 26, 2022 · 2 comments
Open

Migrate piwik.js/matomo.js to Typescript #19144

Findus23 opened this issue Apr 26, 2022 · 2 comments
Labels
RFC Indicates the issue is a request for comments where the author is looking for feedback. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
For Prioritization

Comments

@Findus23
Copy link
Member

matomo.js is quite a complex piece of software and essential for Matomo to work. But that means subtle bugs often slip in and either break things or at least annoy people with logged errors.
Therefore, I am wondering now that we are using typescript in Matomo, if it would be useful migrating matomo.js to typescript (while as a first step keeping the output absolutely identical). It would at the very least avoid bugs like #17926 and maybe also make future updates easier.
This could also allow in the future to make matomo.js more modular and reduce it's size for people who don't need all features. (even though I am not sure how would be the best way to do this as it works a lot easier when bundling the JS in the application than when publishing a JS file).
@Findus23 Findus23 added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. RFC Indicates the issue is a request for comments where the author is looking for feedback. labels Apr 26, 2022
@justinvelluppillai
Copy link
Contributor

That's a cool concept but it'd be a big undertaking I'd say.

@Findus23 Findus23 mentioned this issue Jul 18, 2022
Open
@PowerKiKi
Copy link
Contributor

make matomo.js more modular and reduce it's size for people who don't need all features

This would be a very welcome improvement. We have a very basic use of Matomo. And 25.3 kB of gzipped JS is huge for our use-case. It would be awesome to have an official way to configure a Matomo instance as "minimal" and generate a matomo.js that would probably be closer to 1 kB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC Indicates the issue is a request for comments where the author is looking for feedback. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
For Prioritization
Development

No branches or pull requests
4 participants
@PowerKiKi @justinvelluppillai @Findus23 @innocraft-automation