Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility fixes for PHP 8.1 #19143

Merged
merged 9 commits into from May 17, 2022
Merged

Compatibility fixes for PHP 8.1 #19143

merged 9 commits into from May 17, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 26, 2022 •
edited

Description:

This PR will run the AllTests on PHP 8.1 and includes

  • various fixes for deprecation notices on PHP 8.1
  • couple of test fixes for PHP 8.1
  • fix for possible problems for PHP 8.1 using MySQLi connector
  • fix for PHP 8.0.17 / 8.0.18 & 8.1.4 / 8.1.5 using zlib.output_compression = On

Review

@sgiehl sgiehl force-pushed the php81 branch 5 times, most recently from 767f74a to b7a923d Compare April 27, 2022 15:16
@sgiehl sgiehl force-pushed the php81 branch 2 times, most recently from 072316c to 34e4265 Compare May 6, 2022 08:43
@sgiehl sgiehl force-pushed the php81 branch 3 times, most recently from d50c1e1 to 92f1755 Compare May 6, 2022 11:46
@sgiehl sgiehl force-pushed the php81 branch 3 times, most recently from 2e1c197 to a6342ac Compare May 8, 2022 19:40
@sgiehl sgiehl changed the title Run tests on PHP 8.1 Compatibility fixes for PHP 8.1 May 8, 2022
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 8, 2022
@sgiehl sgiehl added this to the 4.11.0 milestone May 8, 2022
@sgiehl sgiehl marked this pull request as ready for review May 8, 2022 20:47
justinvelluppillai
justinvelluppillai approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@justinvelluppillai justinvelluppillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and tests are passing. I wonder if at some point we want to set the reporting to the PHP8.1 default for previous versions instead of setting it to off for PHP8.1, and update code to reflect but that would be a bigger change.

@justinvelluppillai justinvelluppillai removed the Needs Review PRs that need a code review label May 10, 2022
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 10, 2022
@sgiehl
Copy link
Member Author

sgiehl commented May 10, 2022

@justinvelluppillai Yes. I thought about that as well. The "problem" is that we therefor need to patch the Zend_Db classes, which I'd prefer not to do. Would be better to get rid of them at some point and introduce a new database library or write something own...

@sgiehl sgiehl merged commit 3860159 into 4.x-dev May 17, 2022
@sgiehl sgiehl deleted the php81 branch May 17, 2022 12:07
@sgiehl sgiehl mentioned this pull request May 17, 2022
Closed
11 tasks
@sgiehl sgiehl linked an issue May 17, 2022 that may be closed by this pull request
Fix error in php8.1 running console config:get command #19225
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvelluppillai justinvelluppillai justinvelluppillai approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Fix error in php8.1 running console config:get command
2 participants
@sgiehl @justinvelluppillai